Merged
Conversation
Contributor
|
Great work 👍 |
AsakuraMizu
reviewed
Nov 27, 2025
AsakuraMizu
reviewed
Nov 28, 2025
tests/async.rs
Outdated
Comment on lines
80
to
82
| if i % 2 == 0 { | ||
| flag.store(true, Ordering::SeqCst); | ||
| } |
Contributor
There was a problem hiding this comment.
Consider moving this after barrier.wait().await and before ps.wake(), or f.await just immediately returns in these tasks.
tests/async.rs
Outdated
Comment on lines
98
to
99
| task::yield_now().await; | ||
| assert_eq!(counter.count(), 33); |
Contributor
There was a problem hiding this comment.
Can you remove the counter and carefully check the corresponding task is finished?
AsakuraMizu
approved these changes
Nov 28, 2025
tests/async.rs
Outdated
Comment on lines
85
to
87
| let results = future::join_all(ready).await; | ||
| assert_eq!(results.len(), 33); | ||
| assert!(results.into_iter().all(|r| r.is_ok())); |
Contributor
There was a problem hiding this comment.
[Nitpick] This can be simplified by using try_join_all.
tests/async.rs
Outdated
Comment on lines
95
to
97
| let results = future::join_all(pending).await; | ||
| assert_eq!(results.len(), 32); | ||
| assert!(results.into_iter().all(|r| r.is_ok())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.